Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for validation of signed pipelines #853

Closed
wants to merge 10 commits into from
Closed

Added support for validation of signed pipelines #853

wants to merge 10 commits into from

Conversation

bhanurp
Copy link
Collaborator

@bhanurp bhanurp commented Nov 3, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

@bhanurp bhanurp requested review from yahavi and eyalbe4 November 3, 2023 07:24
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 5, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 5, 2023
yahavi
yahavi requested changes Nov 7, 2023
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
pipelines/manager.go Outdated Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
@bhanurp bhanurp requested a review from yahavi November 13, 2023 11:14
yahavi
yahavi requested changes Nov 23, 2023
View reviewed changes
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
pipelines/services/signedpipelines.go Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@yahavi yahavi added new feature Automatically generated release notes safe to test Approve running integration tests on a pull request labels Nov 23, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 23, 2023
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@bhanurp bhanurp requested a review from yahavi November 28, 2023 23:46
@eyalbe4 eyalbe4 closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 Awaiting requested review from eyalbe4

@yahavi yahavi Awaiting requested review from yahavi

Assignees
No one assigned
Labels
new feature Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bhanurp @yahavi @eyalbe4